Skip to content

feat(eslint): add sort-key, sort prop-types, no bind jsx #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

feat(eslint): add sort-key, sort prop-types, no bind jsx #167

merged 1 commit into from
May 11, 2021

Conversation

@philibea
Copy link
Collaborator

@philibea philibea commented May 11, 2021

  • add warn on sort key and sort proptypes
  • add no bind function ( only arrow function )

@philibea philibea requested review from chambo-e and matthprost May 11, 2021 07:35
@philibea philibea self-assigned this May 11, 2021
chambo-e
chambo-e suggested changes May 11, 2021
View reviewed changes
@philibea philibea force-pushed the add-eslint-rules branch from eb0627e to 76d34d9 Compare May 11, 2021 08:13
@codecov
Copy link

codecov bot commented May 11, 2021 •
edited
Loading

Codecov Report

Merging #167 (f03d4f3) into master (0bb54a7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #167   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          263       264    +1     
  Branches        40        39    -1     
=========================================
+ Hits           263       264    +1
Impacted Files Coverage Δ
packages/use-dataloader/src/DataLoaderProvider.js 100.00% <ø> (ø)
packages/use-dataloader/src/constants.js 100.00% <ø> (ø)
packages/use-dataloader/src/reducer.js 100.00% <ø> (ø)
packages/use-query-params/src/index.js 100.00% <ø> (ø)
packages/use-dataloader/src/useDataLoader.js 100.00% <100.00%> (ø)
packages/use-i18n/src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bb54a7...f03d4f3. Read the comment docs.

@philibea philibea force-pushed the add-eslint-rules branch 2 times, most recently from be6d269 to 3392d10 Compare May 11, 2021 11:24
@philibea philibea requested a review from chambo-e May 11, 2021 11:34
@philibea philibea force-pushed the add-eslint-rules branch from 3392d10 to f03d4f3 Compare May 11, 2021 12:04
@philibea philibea merged commit 41086e8 into master May 11, 2021
@philibea philibea deleted the add-eslint-rules branch May 11, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@chambo-e chambo-e chambo-e approved these changes

@matthprost matthprost matthprost approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@philibea philibea

Labels

eslint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@philibea @chambo-e @matthprost